Refactor/consolidate data files#119
Merged
andytorrestb merged 4 commits intoJul 14, 2026
Merged
Conversation
Case assets (STL, JFH, TCD, flight plan files) can now live in a repo-level data/ directory instead of being copied into every case. resolve_asset_path() checks the case-local folder first, so case-specific files keep priority, then falls back to the shared data/<subdir>/ folder. All pyrpod loaders now resolve config-referenced files through it. JFH output paths intentionally stay case-local. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Every case carried its own copies of shared STL, TCD, JFH, and flight plan files. One canonical copy of each is kept under data/stl, data/tcd, data/jfh, and data/flight_plan; all byte-identical copies are deleted (verified by content hash before removal). Files whose shared name was already taken by different content, or that existed under several case-specific names, were given descriptive canonical names instead: - tcf_16_thrusters.txt, tcf_4_thrusters.txt, tcf_1_thruster.txt, tcf_24_thrusters.txt (previously tcf_<case_name>.txt / tcf.txt) - cylinder_low_res.stl (raw source of cylinder_transformed.stl; data/stl/cylinder.stl is a different high-res mesh) - mold_funnel_high_res.stl / mold_funnel_high_res_transformed.stl (2880-tri funnel; the 208-tri variant keeps the plain name) - square_plate_large_fine.stl (was also square_plate_large.stl) Also removes orphaned duplicates: tests/JFH05.A (identical to data/jfh/JFH05.A, referenced nowhere) and data/tcd/TCD2.txt (identical to tcf_flight_envelopes.txt). Files with the same name but genuinely different content stay case-local; the local-first resolver guarantees they win over data/. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
config.ini tcf/jfh/stl_thruster keys now reference the canonical names in data/ (tcf_16_thrusters.txt, tcf_1_thruster.txt, jfh_base_case.A, mold_funnel_high_res_transformed.stl, ...). Transform scripts read their base STL from data/stl via the repo root; transformed outputs are still written case-locally, where the local-first resolver picks them up. Updates a stale comment pointing at the removed data/tcd/TCD2.txt. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
tdf.csv and ccf.txt hold thruster performance data and cluster placement for a specific case run and are expected to be tuned per case, so they are excluded from the shared data/ consolidation. Restores every case-local tdf.csv, ccf.txt, and tdf_legend.csv exactly as on master, restores data/tcd/tdf.csv to its pre-consolidation content, and drops the consolidated data/tcd copies of ccf.txt and tdf_legend.csv. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.